david2242 / student-competition

It is a CRUD app where registering student's competition result in school.
0 stars 0 forks source link

Create models #3

Closed david2242 closed 2 months ago

david2242 commented 4 months ago

Student:

Competition:

norbfr commented 2 months ago

I have some questions:

  1. What data would the "location" field work with? I see that the type would be string, but why is there a () sign behind it?
  2. Could the "other" field will work as a comment/note functionality? If so, I would give it a suitable name for it.
  3. If I understand correctly, the "subject" and "teacher" fields will function as an array based on the [ ] notation, right?
  4. In the case of the "form" field, more than one of the possible values ​​can be specified, so would this field exist as an array? Is that why the array [ ] notation is behind it?
david2242 commented 2 months ago
  1. Yes, the "()" was not intended. It should store some kind of city i think, like "Budapest", or "Debrecen" etc.
  2. Yes the other field is for any other comments related to the competition, but here is no field for it specified. What suggestion do you have with this naming?
  3. The subject can be an array because the competition can have multiple subject such as ["mathematics", "physics"]. It would be nice to use enums but at the same time it should handle unspecified subjects, like new ones emerging in schools, like "visual culture" :D.
  4. Yeah the form should be an array as well because the competition can have multiple forms like ["oral", "written"].
norbfr commented 2 months ago

Thanks for the answer.

I suggest a name for the "other" field like a "note" or "comment". Which one do you think is appropriate? However if you think we should stick with the original name, that's OK for me.

david2242 commented 2 months ago

Note is perfect, I'll change it on backend as well. Thanks!