david26694 / cluster-experiments

Simulation-based power analysis library
https://david26694.github.io/cluster-experiments/
MIT License
28 stars 3 forks source link

Pb/add relative stochastic perturbators #110

Closed pablobd closed 1 year ago

pablobd commented 1 year ago

In this PR, I am adding:

100% of diff lines are tested having an effect of increasing coverage above 98%.

image

pablobd commented 1 year ago

LGTM. I'm wondering if it would be worth adding a parameter so that every perturbator could be used both as "additive" and as "relative", without the need to define two separate classes.

It's better to keep classes small and focused on what they should do

david26694 commented 1 year ago

Some minor changes, looks great