david26694 / cluster-experiments

Simulation-based power analysis library
https://david26694.github.io/cluster-experiments/
MIT License
27 stars 3 forks source link

143 add more effects in notebook #147

Closed Gabrielcidral1 closed 8 months ago

Gabrielcidral1 commented 9 months ago

Adding more models and splitters to the hypothesis testing comparison

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6c22bff) 96.96% compared to head (24d5127) 96.96%. Report is 2 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #147 +/- ## ======================================= Coverage 96.96% 96.96% ======================================= Files 9 9 Lines 890 891 +1 ======================================= + Hits 863 864 +1 Misses 27 27 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Gabrielcidral1 commented 9 months ago

I had a problem using plotnine version specified due to a conflict with numpy. I bumped plotnine locally to the latest version and it worked. Can this cause any issue here?

Gabrielcidral1 commented 9 months ago

perfect, will do :)

Gabrielcidral1 commented 8 months ago

I think it's ready to go!