david415
commented
9 years ago fixed in this commit https://github.com/david415/HoneyBadger/commit/4917193f6f41447fe3b61ffd1e34f03525d5dc8c
does mischief want to review?
Closed david415 closed 9 years ago
david415
commented
9 years ago fixed in this commit https://github.com/david415/HoneyBadger/commit/4917193f6f41447fe3b61ffd1e34f03525d5dc8c
does mischief want to review?
While I was working on issue number 51 https://github.com/david415/HoneyBadger/issues/51 I came to notice that our "ordered coalesce" did not properly coalesce TCP stream segments into our reassembly ring. I was using this dev branch: https://github.com/david415/HoneyBadger/tree/51-fix-retrospective-1 and it was this extra log print statement that alerted me to the duplicate Sequenced segments being appended to our "TCP reassembly ring buffer": https://github.com/david415/HoneyBadger/commit/b4b356869d419804fa99f2b37e0f58136e0e9fce
like this... for example:
2015/05/18 09:31:14 adding from ordered-coalesce (262046326, 262048014) 2015/05/18 09:31:14 adding from ordered-coalesce (262046766, 262048014) 2015/05/18 09:31:14 adding from ordered-coalesce (262048014, 262049474) 2015/05/18 09:31:14 adding from ordered-coalesce (262048014, 262049914)