TcpIpFlow's Equal receiver method doesn't always work

[david415]

A mismatched flow type will cause Equal to always return false; as is the case when a TcpIpFlow is constructed with IPv6 addresses and compared to a flow constructed with IPv4 addresses. We should do two things:

• carefully audit the code that creates flows and make sure they have the correct endpoint types
• put a panic condition in Equal when called with mismatched types

I believe this is unlikely to affect honeybadger detection since there would not be mismatched flow endpoint types.

[david415]

• added panic condition to Equal https://github.com/david415/HoneyBadger/commit/6d01c64db61df8df2b66defed1e5cf2f5e1a9b37
• code audit: nope. but i did notice all the tests passed.

[david415]

closing for now