david4599 / PricehaxBT

Wireless tool to communicate with IR based ESLs from a smartphone ;-)
GNU General Public License v3.0
58 stars 7 forks source link

Add support for 1628 #3

Closed dandri closed 1 year ago

david4599 commented 1 year ago

Hey, thanks for the pull request.

First, it seems the 1627, 1628 and 1639 are new product types because of the number 6 that I've never saw before here. The 1243 is an old model but I didn't see it either. Can you provide more information or pictures about them?

I guess you added the "EXPERIMENTAL" text on the 16xx models because you couldn't test to upload images on them. Can you confirm that?

Then, there are some changes I would like to suggest.

case 1627: case 1628: MainActivity.this.scaneitype.setText("Type: " + MainActivity.this.PLType + " (SmartTag HD L Red 296x128) EXPERIMENTAL"); MainActivity.this.wi = 296; MainActivity.this.hi = 128; MainActivity.this.ESLType = 2; MainActivity.this.ESLTypeColor = true; break;


- Based on the resolution and color type you set for the 1639 model, it seems to be quite the same as the 1339 one:
```java
case 1339:
case 1639:
    MainActivity.this.scaneitype.setText("Type: " + MainActivity.this.PLType + " (SmartTag HD S Red 152x152) EXPERIMENTAL");
    MainActivity.this.wi = 152;
    MainActivity.this.hi = 152;
    MainActivity.this.ESLType = 2;
    MainActivity.this.ESLTypeColor = true;
    break;

Now, to avoid polluting the commit history with wrong and revert commits, I will close this pull request and I let you create another one (would be nice to do it from a temporary branch as explained above) with only the suggested changes in the MainActivity.java.

dandri commented 1 year ago

Yes i had "Experimental" when I added the first one since I had not tested on it then.

I have some pictures of the ESLs im adding, I believe they are just newer versions of the older ones. I have tested all of the new ones but not the Continuum one since they always have a sticker on them that is over the barcode. I'm not 100% sure if its a E4 or E5 Continuum yet.

I will create a temporary branch to push from and fix mainactivity. I appreciate all the help. SmartSelect_20230430_153122_Pricehax BT 20230430_153044 20230430_153032 20230430_153019 SmartSelect_20230428_155054_Pricehax BT 20230427_181540 SmartSelect_20230427_181513_Pricehax BT

dandri commented 1 year ago

Forgot one pic of 12xx 20230424_121411