Closed dandri closed 1 year ago
Yes i had "Experimental" when I added the first one since I had not tested on it then.
I have some pictures of the ESLs im adding, I believe they are just newer versions of the older ones. I have tested all of the new ones but not the Continuum one since they always have a sticker on them that is over the barcode. I'm not 100% sure if its a E4 or E5 Continuum yet.
I will create a temporary branch to push from and fix mainactivity. I appreciate all the help.
Forgot one pic of 12xx
Hey, thanks for the pull request.
First, it seems the 1627, 1628 and 1639 are new product types because of the number 6 that I've never saw before here. The 1243 is an old model but I didn't see it either. Can you provide more information or pictures about them?
I guess you added the "EXPERIMENTAL" text on the 16xx models because you couldn't test to upload images on them. Can you confirm that?
Then, there are some changes I would like to suggest.
Only the "MainActivity.java" file has to be edited. No need to add the others (.idea folder, app/src/app/local.properties). Also, to separate sources from built releases, I prefer to avoid committing the apk file. I will compile it myself and add it to the "Releases" section of the repo.
The location where you added the 1628 model will interfere with the "case 1217:" just above. This will set the 1217 type as 1628 which is wrong because the 1217 is the same as 1265 (Continuum E5 HCS). You should change that part, for example like that:
case 1627: case 1628: MainActivity.this.scaneitype.setText("Type: " + MainActivity.this.PLType + " (SmartTag HD L Red 296x128) EXPERIMENTAL"); MainActivity.this.wi = 296; MainActivity.this.hi = 128; MainActivity.this.ESLType = 2; MainActivity.this.ESLTypeColor = true; break;
Also, I noticed that you are making changes to the repo's URL in the readme inside your main branch to match to your forked repo's URL but this change is added to the pull request which I can't accept. To avoid this situation, you should create a temporary branch, switch to it, add the ESL types to the MainActivity.java and submit a pull request from that branch. That way, you can change things in your main branch without affecting the pull request like it is happening here.
Now, to avoid polluting the commit history with wrong and revert commits, I will close this pull request and I let you create another one (would be nice to do it from a temporary branch as explained above) with only the suggested changes in the MainActivity.java.