davidADSP / Generative_Deep_Learning_2nd_Edition

The official code repository for the second edition of the O'Reilly book Generative Deep Learning: Teaching Machines to Paint, Write, Compose and Play.
https://www.oreilly.com/library/view/generative-deep-learning/9781098134174/
Apache License 2.0
1.12k stars 428 forks source link

fix h5py issue and some #39

Closed changyaochen closed 2 months ago

changyaochen commented 2 months ago

In this PR, we fix 1 issue and make few other no-op improvements.

Fix

The issue is when running docker compose build, I'm seeing the issue with installing h5py (required by tensorflow), as follows:

...
21.92       Building h5py requires pkg-config unless the HDF5 path is explicitly specified using the environment variable HDF5_DIR. For more information and details, see https://docs.h5py.org/en/stable/build.html#custom-installation
21.92       error: pkg-config probably not installed: FileNotFoundError(2, 'No such file or directory')
21.92       [end of output]
21.92   
21.92   note: This error originates from a subprocess, and is likely not a problem with pip.

The solution is to installed the required Linux packages to the Dockerfile. After that, it runs as expected in bringing up the Jupyter server locally.

Improvements