davidB / git2_credentials

Provide credentials function to used with git2::RemoteCallbacks.credentials
Apache License 2.0
21 stars 4 forks source link

Pest fixes, and avoid passphrase prompt when possible #30

Closed stevelr closed 1 year ago

stevelr commented 2 years ago
davidB commented 2 years ago

Thanks, I integrate the support of comment and ignore cased, based on you test cases (but with a different impl) , you can see the commit linked above. But that generate conflict with your PR and invalidate. Do you want to rebase and update the PR or else close this PR and create a new one for "avoid prompting for passphrase: if ssh key is unencrypted, no passphrase is needed. if encrypted, use ssh-agent so user is only prompted once instead of each iteration" or open an issue with a test case (and then I will try to implement myself

I didn't merge your PR regarding my comment above ("what happen when no ssh-agent?"), and the need to release a new version for the latest version of git2 (and I would like to at least support comment).

Thanks again.