davidB / gradle-getdown-plugin

A gradle plugin to bundle java app + jre with getdown support
Creative Commons Zero v1.0 Universal
16 stars 3 forks source link

IMG_SHORTCUTS_DEFAULT has no default #24

Open busche opened 8 years ago

busche commented 8 years ago

When setting up a new project as documented on the Github page (extending buildscript dependencies, applying the plugin, configuring the getdown part ...) and running the assembleApp task, I get the following error

:makeIcons FAILED

FAILURE: Build failed with an exception.

My environment: (embedded Gradle in Eclipse Build id: 20160218-0600) Gradle Version: 2.12 Java Home: C:\Program Files\Java\jdk1.8.0_66 JVM Arguments: None Program Arguments: None Gradle Tasks: assembleApp

The documentation does not state anything for this property. What shall I do / configure?

busche commented 8 years ago

OK, the bug should be located here: https://github.com/davidB/gradle-getdown-plugin/blob/ef55713d18a6464355a5e6e767fa4530731f6af9/src/main/groovy/bundles/GetdownPlugin.groovy#L70 use absolute referencing to IMG_SHORTCUTS_DEFAULT

busche commented 8 years ago

workaround:

davidB commented 8 years ago

Thanks for reporting, I'll update the doc and fix it (in the new renamed plugin).

lwouis commented 8 years ago

Any news on this? I'm getting the same error today on a fresh setup. I don't know Groovy so I have no clue what IMG_SHORTCUTS_DEFAULT is, and what I could do to fix this.

Ali-RS commented 8 years ago

David I am getting the same error.

busche commented 8 years ago

Well, I've posted the workaround above, which works. Maybe @davidB gives a pointer to the renamed plugin or changes it here. I am not using the plugin currently, and since the shortcut depends on your software, it is best to fix it locally at your place.

Ali-RS commented 8 years ago

Well, I've posted the workaround above, which works.

Yes, @busche i already fixed it locally with your workaround. Thanks.