Auto-detect and use HTTP-Proxy

davidB / gradle-getdown-plugin

A gradle plugin to bundle java app + jre with getdown support

Creative Commons Zero v1.0 Universal

16 stars 3 forks source link

Auto-detect and use HTTP-Proxy #28

Closed busche closed 8 years ago

busche commented 8 years ago

Check whether both system properties http.proxyPort and http.proxyHost are configured. If so, configure a HTTP Proxy to download a JRE.

This solves issue #25

busche commented 8 years ago

I am fine with adding further modifications - just let me know. Since a customer waits for this extension, I would be glad if you could release a new version once all potential quality issues are fixed :-) The extended code is tested behind a HTTP proxy (just the HTTP-part is configured). I believe the code is still working without any HTTP proxy in the network when no HTTP proxy is configured as well.

davidB commented 8 years ago

LGTM, I'll try to push upload a new version today or tomorrow.

davidB commented 8 years ago

0.4.5 with your fix is released