Closed ahmetb closed 4 years ago
I fix the addition, but release I would like your opinion about the following case. How to display value (result of sum, or direct value) when they are display in the higher System Unit (in the column)
WDYT ?
Yeah it's a tough thing to figure out.
I recommend you figure out what the String() function of Go time.Duration value does. Because it just stores an int64 (nanoseconds) but it prints values like 5s 4.7ms 116ns.
Please don't "round" values. 1700 is neither 1k nor 2k.
I'm not convince by the readability of of column with "3Gi 0Ki 6". So
I'll release a version 0.6.0 with the fix about the sum and rounding.
version 0.6.0 is pushed to krew-index https://github.com/kubernetes-sigs/krew-index/pull/366
Works now, thanks a whole bunch.
SUPERB PLUGIN! Thanks for bringing it to krew.
I think I've discovered a bug that causes not all limits/requests to be shown
So I have these pods in my knative-serving namespace:
click here to see pods YAML
to copy paste
resources
sections from those pods:So when I run the plugin I get this view:
As you might notice, none of cpu limits are mentioned in the chart, like 20m, 100m, 30m, 300m.
Similarly
cpu
part of the chart doesn't even list these pods that specifyrequests.cpu
so clearly.I hope you can fix, I'll use it in my krew.dev demos going forward!