Added missing dependency specs2-junit integration

davidB / scala-archetype-simple

a simple maven archetype for project in scala

Creative Commons Zero v1.0 Universal

109 stars 95 forks source link

Added missing dependency specs2-junit integration #13

Closed maximn closed 8 years ago

maximn commented 8 years ago

When running mvn test getting

[ERROR] /Users/.../src/test/scala/samples/specs.scala:18: error: not found: type JUnitRunner
[ERROR] @RunWith(classOf[JUnitRunner])
[ERROR]                  ^
[ERROR] one error found

Added -

    <dependency>
      <groupId>org.specs2</groupId>
      <artifactId>specs2-junit_${scala.compat.version}</artifactId>
      <version>2.4.16</version>
    <scope>test</scope>
    <dependency>

davidB commented 8 years ago

thx

maximn commented 8 years ago

Sorry, but I think you need to revert this PR.

It's not in the published archetype so I thought it's missing but it's in the code. Now you have this dependency twice

maximn commented 8 years ago

And also I didn't close the <dependency> tag. Please revert this pull request ASAP.