search

davidB / scala-maven-plugin

The scala-maven-plugin (previously maven-scala-plugin) is used for compiling/testing/running/documenting scala code in maven.
https://davidb.github.io/scala-maven-plugin/
The Unlicense
560 stars 151 forks source link

Set skip's user property to maven.scaladoc.skip #700

Closed wangyum closed 1 year ago

wangyum commented 1 year ago

-Dskip=true also skips building the test jar. This PR makes the user property to maven.scaladoc.skip.

At least two projects use this property: https://issues.apache.org/jira/browse/SPARK-43461 https://github.com/apache/kyuubi/blob/1e310a0818f23dd7b8f2d4afd17795794fed46ea/pom.xml#L238

wangyum commented 1 year ago

cc @davidB

slandelle commented 1 year ago

Hello,

First, please explain the problem and provide a reproducer (sample project, step by step) or better, an integration test included here: https://github.com/davidB/scala-maven-plugin/tree/master/src/it

Then, this is a breaking change. Have you considered the current users of this skip property? What would the behavior for them be if we introduce the change you're suggesting?

At least two projects use this property: https://issues.apache.org/jira/browse/SPARK-43461 https://github.com/apache/kyuubi/blob/1e310a0818f23dd7b8f2d4afd17795794fed46ea/pom.xml#L238

No idea what they use this for as it's not supported here. How is this relevant?

wangyum commented 1 year ago

Thank you @slandelle I solved this problem by adding a new property: https://github.com/apache/spark/pull/41141/commits/bb6329e60cf77a3c12a3e1fbeeca6b2f9d63cc66