search

davidB / scala-maven-plugin

The scala-maven-plugin (previously maven-scala-plugin) is used for compiling/testing/running/documenting scala code in maven.
https://davidb.github.io/scala-maven-plugin/
The Unlicense
554 stars 150 forks source link

Fix scalaCompatVersion check, closes #732 #740

Closed jozic closed 5 months ago

jozic commented 7 months ago

@slandelle per discussion in #732, here's a PR with a test

jozic commented 7 months ago

Hey @davidB, thanks for checking it out! in fact such a test exists in https://github.com/davidB/scala-maven-plugin/tree/master/src/it/mismatchedScalaVersions i just coped it and modified to make sure we don't have the warning when compat version is set and scala versions are compatible

or do you talk about some other test?

jozic commented 7 months ago

@slandelle do you mind checking this quickly? it's pretty small )

LeRiton commented 5 months ago

Hi everyone, Thanks @jozic for the patch! Any plan to merge this for the next release?