search

davidB / yuicompressor-maven-plugin

maven's plugin to compress (Minify / Ofuscate / Aggregate) Javascript files and CSS files using YUI Compressor
http://davidb.github.io/yuicompressor-maven-plugin/
GNU Lesser General Public License v2.1
122 stars 48 forks source link

Please update the plugin's embedded version of JSLint.js #64

Open gmazza opened 11 years ago

gmazza commented 11 years ago

Hi the latest JSLint.js has many more settings (such as the "vars" setting): https://github.com/douglascrockford/JSLint/blob/master/jslint.js#L288

than the three-year old one packaged with the plugin: https://github.com/davidB/yuicompressor-maven-plugin/blob/master/src/main/resources/jslint.js#L53

Right now I can't use /jslint vars: true/ in a JavaScript file because the yuicompressor-maven-plugin's jslint.js version doesn't have that option (the plugin's jslint goal just returns an error and halts.)

Could you please update the plugin to the latest JSLint.js?

davidB commented 11 years ago

In an other issue #63 you wrote that you use jslint-maven-plugin. So what is the issue ?

After (re) reading both issue, may be I should removed jslint from the next version ?

gmazza commented 11 years ago

This is dependent on #63. If you decide to keep it, you should update it to the latest one as it saves people a lot of time and aggravation as they can't understand why their jslint settings aren't working.