search

davidLin7692 / pymodbus

Automatically exported from code.google.com/p/pymodbus
0 stars 0 forks source link

Instantiation of synchronous UDP client does not work #40

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
While reading the code I stumbled over the following problem:
The constructor of pymodbus.client.sync.ModbusUdpClient attempts
to create a ModbuSocketFramer (no "s" at the end of "Modbu").

I've attached a small patch for fixing this problem including some
unittests.

Beware that the current version of the test_client module imports
the unittest module from twisted.trial - this does not allow to
actually run unittests. I've replaced it by a Python's unittest 
module for now. If  you'd rather import twisted.trial.unittest,
please adapt my patch accordingly.

Thanks, Albert

Original issue reported on code.google.com by albert.k...@gmail.com on 22 Feb 2011 at 2:22

Attachments:

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r119.

Original comment by Bashw...@gmail.com on 22 Feb 2011 at 2:49