search

davidMcneil / mnist

MNIST data set parser https://crates.io/crates/mnist
20 stars 9 forks source link

Compilation error on Windows #10

Closed relf closed 10 months ago

relf commented 2 years ago

Follow-up of linfa compilation problem due to mnist 0.5. It comes from the use of cfg! in download.rs which does not remove any code unlike #[cfg], hence the error on Windows.

quietlychris commented 2 years ago

I'll try putting together a fix later today, but won't have a Windows machine to build on. Would you mind testing that code for this library and compiling linfa with the git repository as a dependency one it's ready?

relf commented 2 years ago

@davidMcneil, thank you for merging #11. Do you think you could publish a new version of the crate in the coming weeks? It would be very much appreciated.

quietlychris commented 1 year ago

@davidMcneil When you get a chance, would you mind potentially cutting a new update to crates.io now that this fix has been merged? There's a small PR in the dfdx library that's currently a bit stuck due to a CI error on Windows that seems to be a result of this. Thanks for your consideration!

Absolutely no pressure, but if you're interested, the Rust-ML group (GH, crates.io) would also be happy to be added as a co-maintainer for this crate in case you find yourself with limited availability in the future.

davidMcneil commented 10 months ago

Published https://crates.io/crates/mnist