search

davidMcneil / rants

An async NATS client library for the Rust programming language.
Apache License 2.0
81 stars 11 forks source link

Implement optimized wildcard request dispatching #3

Closed film42 closed 4 years ago

film42 commented 4 years ago

This implements the "Support improved request-reply implementation" item of the TODO list in the Readme.

This reduces the sub/unsub churn caused by a naive implementation of the request method. This is the method used in the official nats.go client.

When a timeout on request happens, the request method is responsible for cleaning up. The request handler will always remove the subscription handle when a message has been received.

davidMcneil commented 4 years ago

When a timeout on request happens, the request method is responsible for cleaning up. The request handler will always remove the subscription handle when a message has been received.

This is interesting. In the timeout case, there is no way for the user to clean up because they do not know the subject name and dont have access to the internal request_inbox_mapping to remove the subject name. Not sure what the best fix is? Dont need a fix for this PR, but I will file an issue.

film42 commented 4 years ago

This is interesting. In the timeout case, there is no way for the user to clean up because they do not know the subject name and dont have access to the internal request_inbox_mapping to remove the subject name. Not sure what the best fix is? Dont need a fix for this PR, but I will file an issue.

The nats.go client adds a timeout option and selects on both channels to always be able to cleanup before returning to the caller. It might be worth adding a timeout arg to the request function?

film42 commented 4 years ago

@davidMcneil Thank you for the great feedback. I like those ideas!