search

davidacm / NVDA-IBMTTS-Driver

This project is aimed at developing and maintaining the NVDA IBMTTS driver. IBMTTS is a synthesizer similar to Eloquence. Please send your ideas and contributions here!
GNU General Public License v2.0
56 stars 23 forks source link

Abbreviation dictionary toggle #34

Closed Mohamed00 closed 3 years ago

Mohamed00 commented 4 years ago

This pull request adds a checkbox to the IBMTTS settings to enable or disable the abbreviation dictionary. Credit goes to @ultrasound1372 for this code.

amirsol81 commented 4 years ago

So when is this going to be released? All-capital words like FAQ and WHO will benefit a lot!

Mohamed00 commented 4 years ago

Unfortunately FAQ won't be fixed by this PR, you'll need to add a dictionary entry for it in main.dic. This toggles abbreviations like NY, TX, wk, and Robt. I'm not sure what's happened to David unfortunately, however development is continuing on this fork. Click on the tags link to get the latest release.

amirsol81 commented 4 years ago

Unfortunately FAQ won't be fixed by this PR, you'll need to add a dictionary entry for it in main.dic. This toggles abbreviations like NY, TX, wk, and Robt. I'm not sure what's happened to David unfortunately, however development is continuing on this fork. Click on the tags link to get the latest release.

Quite interestingly, I corrected "FAQ" a while ago via my Root.dic dictionary file (whose latest release is attached). But I think it would be interesting to also support the ABBR.dic file as it can handle abbreviations, even the FAQ/WHO type, more elegantly. Currently the project doesn't support the reading/processing of ABBR.dic/ENUABBR.dic file. I'll also get the latest release via your provided link. Thanks. Root.zip

Mohamed00 commented 4 years ago

Abbr.dic should be supported in the latest release of that fork. You can also rename the dictionaries to enuabbr, enumain or enuroot.dic for compatibility with SAPI versions, though the old dictionaries will also still load.

amirsol81 commented 4 years ago

Abbr.dic should be supported in the latest release of that fork. You can also rename the dictionaries to enuabbr, enumain or enuroot.dic for compatibility with SAPI versions, though the old dictionaries will also still load.

Man, I love what you are doing there! Awesome job! I just updated to 20.07-x0_personal. Is this the latest? And do you think abbreviations like WHO should only be corrected via the ABBR.dic dictionary? Once again, thanks for bringing this great branch to my attention.

Mohamed00 commented 4 years ago

Yes, it is the latest, though there have been commits made since then that should be made available in a release soon enough, or you could download the repository and replace the PY files in the addon directory. The abbreviation for WHO is probably best corrected in the abbreviation dictionary, though it should be noted that if the abbreviation dictionary option is disabled, enuabbr.dic is disabled as well.

On 7/7/2020 4:37 AM, amirsol81 wrote:

Abbr.dic should be supported in the latest release of that fork.
You can also rename the dictionaries to enuabbr, enumain or
enuroot.dic for compatibility with SAPI versions, though the old
dictionaries will also still load.

Man, I love what you are doing there! Awesome job! I just updated to 20.07-x0_personal. Is this the latest? And do you think abbreviations like WHO should only be corrected via the ABBR.dic dictionary? Once again, thanks for bringing this great branch to my attention.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/davidacm/NVDA-IBMTTS-Driver/pull/34#issuecomment-654692921, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADY4AYCJ4J56XZMLZP4TQY3R2LNFRANCNFSM4MDOUBKA.

Mohamed00 commented 3 years ago

Since this was merged as part of the latest commits, closing.