search

davidacm / NVDA-IBMTTS-Driver

This project is aimed at developing and maintaining the NVDA IBMTTS driver. IBMTTS is a synthesizer similar to Eloquence. Please send your ideas and contributions here!
GNU General Public License v2.0
56 stars 23 forks source link

English documentation missing from add-on package #68

Closed tmthywynn8 closed 2 years ago

tmthywynn8 commented 2 years ago

Not sure how long this has been going on, but it appears that the English documentation (found in README.md) is not included in the add-on package. In other words, one cannot open the NVDA menu (NVDA+N), Tools (T), Manage add-ons dialog (A), choose the IBMTTS driver, and activate the Add-on help button (Alt+H) when NVDA is set to English.

lbk2907 commented 2 years ago

I already tell him about this. It starting after version 21.11. I mean 21.11 is the last version that contain English documentation.

From: Timothy Wynn Sent: Tuesday, July 5, 2022 11:18 AM To: davidacm/NVDA-IBMTTS-Driver Cc: Subscribed Subject: [davidacm/NVDA-IBMTTS-Driver] English documentation missing fromadd-on package (Issue #68)

Not sure how long this has been going on, but it appears that the English documentation (found in README.md) is not included in the add-on package. In other words, one cannot open the NVDA menu (NVDA+N), Tools (T), Manage add-ons dialog (A), choose the IBMTTS driver, and activate the Add-on help button (Alt+H) when NVDA is set to English. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

lbk2907 commented 2 years ago

I have found another bug that is the 22 kHz didn’t show up even I already switch to IBM binary.

From: Timothy Wynn Sent: Tuesday, July 5, 2022 11:18 AM To: davidacm/NVDA-IBMTTS-Driver Cc: Subscribed Subject: [davidacm/NVDA-IBMTTS-Driver] English documentation missing fromadd-on package (Issue #68)

Not sure how long this has been going on, but it appears that the English documentation (found in README.md) is not included in the add-on package. In other words, one cannot open the NVDA menu (NVDA+N), Tools (T), Manage add-ons dialog (A), choose the IBMTTS driver, and activate the Add-on help button (Alt+H) when NVDA is set to English. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

davidacm commented 2 years ago

Hi @tmthywynn8

I changed my copy of NVDA to english, and the documentation in English is opened without issues. Also readme.html is present in doc/en folder.

Can you check if this happen with the last version of IBMTTS? The last version is 22.07.3.

davidacm commented 2 years ago

Hi @lbk2907, the issue you commented should be opened in another issue, describing all information about your system environment.

lbk2907 commented 2 years ago

Hey there David. The EN folder is missing from the IBMTTS package.

From: David CM Sent: Tuesday, July 5, 2022 11:44 AM To: davidacm/NVDA-IBMTTS-Driver Cc: lbk2907; Comment Subject: Re: [davidacm/NVDA-IBMTTS-Driver] English documentation missing fromadd-on package (Issue #68)

Hi @tmthywynn8 I changed my copy of NVDA to english, and the documentation in English is opened without issues. Also readme.html is present in doc/en folder. Can you check if this happen with the last version of IBMTTS? The last version is 22.07.3. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

lbk2907 commented 2 years ago

Ok. I’ll do it now.

From: David CM Sent: Tuesday, July 5, 2022 11:46 AM To: davidacm/NVDA-IBMTTS-Driver Cc: lbk2907; Mention Subject: Re: [davidacm/NVDA-IBMTTS-Driver] English documentation missing fromadd-on package (Issue #68)

Hi @lbk2907, the issue you commented should be opened in another issue, describing all information about your system environment. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

tmthywynn8 commented 2 years ago

Hello @davidacm, I downloaded the latest release of the add-on (v22.07.3) from here: https://github.com/davidacm/NVDA-IBMTTS-Driver/releases/download/v22.07.3/IBMTTS-v22.07.3.nvda-addon

Unfortunately, when I opened the add-on in, say, 7-zip, the only folders present in the doc folder are de, es, fr, pt_br, pt_pt, and zh_CN, and am unsure how your copy has readme.html in the doc/en folder.

Thanks, Timothy

davidacm commented 2 years ago

Sorry. It's because the machine used to construct the add-on in github, seems to be case sensitive, so it doesn't happen on my local machine. I changed the name of the readme, but git does not recognize it as a change. I hope that the name change will be set in the next commit, I don't have commits to send yet.

I will set the package of the latest release manually.

lbk2907 commented 2 years ago

Thanks.

From: David CM Sent: Tuesday, July 5, 2022 12:28 PM To: davidacm/NVDA-IBMTTS-Driver Cc: lbk2907; Mention Subject: Re: [davidacm/NVDA-IBMTTS-Driver] English documentation missing fromadd-on package (Issue #68)

Sorry. It's because the machine used to construct the add-on in github, seems to be case sensitive, so it doesn't happen on my local machine. I changed the name of the readme, but git does not recognize it as a change. I hope that the name change will be set in the next commit, I don't have commits to send yet. I will set the package of the latest release manually. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

tmthywynn8 commented 2 years ago

Forgot to follow-up. The latest add-on binary from v22.07.3 now includes the English documentation. Thank you.

tmthywynn8 commented 2 years ago

Reopening issue because the English documentation is once again missing from the 22.08 release. Is there some sort of setting in the add-on packaging process which ignores the English files?

davidacm commented 2 years ago

That's because the automated process on github is using a linux machine, and the file system is case sensitive. The builder looks for a file called "readme.md", but the file for some reason was renamed to "README.md" at some point. I renamed it again, I checked and looks that this fixed the issue. Can you confirm if all is OK now?

tmthywynn8 commented 2 years ago

Perfect. Confirmed that English documentation is now present in v.22.08.1. Thank you so much for the quick fix.