search

davidacm / NVDA-IBMTTS-Driver

This project is aimed at developing and maintaining the NVDA IBMTTS driver. IBMTTS is a synthesizer similar to Eloquence. Please send your ideas and contributions here!
GNU General Public License v2.0
56 stars 23 forks source link

Crash expression issue in eloquence's german language #88

Closed schulle4u closed 1 year ago

schulle4u commented 1 year ago

Only happens with eloquence libraries enabled, and if german language is set.

Expression: Video-Enco (taken from the word Video-Encodierungsoptionen

I know it is recommended to generally use Viavoice libraries, but maybe this can be added to the crash expressions list anyway.

Mohamed00 commented 1 year ago

Fixed. This doesn't affect any IBMTTS builds, so the code was adjusted accordingly.

Mohamed00 commented 1 year ago

Update. It's not just Video-Encodierungsoptionen, there's a whole new can of worms that deal with the words video and audio. Just updated the expression to catch more cases. Can you try the latest commit and make sure it doesn't introduce any regressions in German?

schulle4u commented 1 year ago

The only thing I notice so far is generally a longer pause between parts of hyphenated words containing crash expressions (character level set to some), but the crashes itself are gone now. I'll work with these new fixes and see what happens, but for the moment everything looks OK. 👍

Mohamed00 commented 1 year ago

Yes, you'll see that because of the way the expression separates the different part of the string. It breaks it up at the dash, and inserts a space before the second part. That's the closest I was able to get to fixing the crash without inserting too much unnatural intonation.