search

davidacm / NVDA-IBMTTS-Driver

This project is aimed at developing and maintaining the NVDA IBMTTS driver. IBMTTS is a synthesizer similar to Eloquence. Please send your ideas and contributions here!
GNU General Public License v2.0
56 stars 23 forks source link

IBMTTS related error in log of recent NVDA Alpha builds after startup. #92

Closed kara-louise closed 1 year ago

kara-louise commented 1 year ago

After starting the latest NVDA alpha build (28406,bcc7f254) and others released during the last week, the add-on displays an error in the log even though it still works. I'm running version 23.5.2 of the Add-on. It could well be a bug in the alpha build that might get fixed causing it, but I'm letting you know in case whatever it is makes it to the next stable build. I've attached a copy of the log containing the error message. I'm running the alpha as a portable app if that makes any difference. IBMTTS Error.log

CyrilleB79 commented 1 year ago

@davidacm, can you acknowledge if you have seen this issue.

This issue is 100% reproductible. It does not impact the TTS usage.

But I think that it prevents the add-on from updating itself. Thus, if you can provide a fix before NVDA 2023.2, or better before NVDA 2023.2beta1, this would prevent stable NVDA users (or beta users) from missing future updates; only alpha users would be impacted and would need to update manually.

Note: The cause of the bug is an evolution in NVDA's core functions. Since you are using functions that are not part of the API (since they start with an underscore) your add-on breaks even if the next NVDA release is not an API-breaking release.

amirsol81 commented 1 year ago

@davidacm I'm running the latest NVDA alpha, and IBMTTS no longer appears in NVDA's Settings window. In other words, we can no longer use NVDA's Settings window to specify the location of ECI libraries, update the add-on, etc. The TTS engine itself functions properly though.

amirsol81 commented 1 year ago

@davidacm The first Alpha which removed IBMTTS from the Settings window is V28351.

ultrasound1372 commented 1 year ago

Another duplicate of #93. It happens because the add-on was trying to import a prefab dialog from NVDA which either no longer exists or has simply been moved due to the add-on store refactor. There is a direct correlation between add-on store and this error.