server: fix error reporting and logic for /keys handler

davidallendj / opaal

Tool to automate the OAuth 2.0/OIDC flows

MIT License

1 stars 3 forks source link

server: fix error reporting and logic for /keys handler #13

Closed dev-zero closed 3 months ago

dev-zero commented 3 months ago

restores proper error reporting to include the host dialed, and fixes the tautological comparison jwks == nil in the recovery path (which go static analysis would have pointed out) to properly refetch the server config and try again as intended

davidallendj commented 3 months ago

Did you mean the /keys handler? I don't see any changes here for /token.

dev-zero commented 3 months ago

@davidallendj yes, you are right. I got an error triggered in /keys from bss asking for /tokens (still have to figure out how that redirect/flow happened). Commit is now signed.

davidallendj commented 3 months ago

Thanks! I think I've seen an issue like that before that I thought we fixed. Want to open an issue with the logs so I can take a look at it?

I'll go ahead a merge this and close.