search

davidalpert / go-git-mob

A golang port of the nodejs git-mob plugin
MIT License
6 stars 2 forks source link

🐛 Bug: co-authors not cleared from message template when returning to git solo #88

Closed davidalpert closed 2 years ago

davidalpert commented 2 years ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Install go-git-mob
  2. Start mobbing 
    git mob ad
  3. Stop mobbing 
    git solo

Expected behavior The mob configuration has been reset and I can make new commits without any Co-Authored-By annotations.

Actual behavior The mob configuration remains in the global git template (e.g. ~/.gitmessage) which is read by VSCode, [Fork](https://www.fork.dev), and other git clients, causingCo-Authored-By` annotations to appear even though we have returned to solo work.

Additional context As we have basically committed to the prepare-commit-msg hook approach, updating the message template seems redundant. I suggest that we remove all updates to the message template.

teezzan commented 2 years ago

Can you assign this to me? @davidalpert

davidalpert commented 2 years ago

@teezzan this codebase started as a port of the Nodejs git-mob tool.

If you have any questions about how the code is organized hit me up here or in slack.

davidalpert commented 2 years ago

the code behavior was addressed by https://github.com/davidalpert/go-git-mob/pull/89

https://github.com/davidalpert/go-git-mob/pull/94 addresses the broken feature specs