Closed IanButterworth closed 2 years ago
@davidanthoff I think this is looking good to me now.
If you agree and you'd like me to handle releasing https://github.com/davidanthoff/ElectronBuilder/pull/5 and this PR, feel free to give me the necessary rights on the two repos
Bump 🙏
Is the way I switched
escape
forescapeuri
ok?
Good question ;) As far as I can tell, the docs for the encoding methods in URIs.jl are wrong and I don't fully understand the logic of the design there... But if tests pass, lets go with it for now.
We have a custom, new implementation for uris in the LS (https://github.com/julia-vscode/LanguageServer.jl/tree/master/src/URIs2), at some point we'll probably move that into its own package, and at that point I'll probably switch this package here over. But no rush, URIs2 probably needs a bit more work first.
This updates to electron v19.0.4 via https://github.com/davidanthoff/ElectronBuilder/pull/5
I released the tarballs on my fork to test CI here. That will need changing back once CI passes and that PR is released.
Fixes #103 Fixes #104 Fixes #105
Other notable changes:
retval
escape
forescapeuri
ok?URI("file://test.html")
test form was silently not showing the page on previous Electron.jl version tests. I switched it out to an absolute pathRemaining issues
I see the following upstream bug warning locally on Intel MacOS
M1 MacOS (thanks @giordano)
On ubuntu CI this error is spammed
but locally on ubuntu I don't see any errors:
I believe it's because the ubuntu runner needs GLFW