davidanthoff / Electron.jl

Julia wrapper for Electron

Other

86 stars 19 forks source link

Filepaths #18

Closed davidanthoff closed 4 years ago

davidanthoff commented 6 years ago

First needs a newer version of FilePaths tagged.

vtjnash commented 6 years ago

Will it continue to be possible to not load FilePaths.jl, or should I just fork this repo?

davidanthoff commented 6 years ago

Is there a problem with FilePaths.jl?

vtjnash commented 6 years ago

Just adds unwanted complexity but doesn't solve any problems for me.

davidanthoff commented 6 years ago

Well, it does make some of the scenarios I'm working on easier, so I do want to add this. I think FilePaths.jl is a harmless small package, so hopefully the sheer existence of that doesn't require a fork.

If you still need some of the stuff in contrib, I'd be happy to keep that around. I just thought you had moved that into URIParser.jl.

davidanthoff commented 6 years ago

Oh, and one more thing: if there is actually any problem with FilePaths.jl (breaks something, doesn't install, anything), please let me know, because then we could certainly reconsider the decision to take a dependency on it.

codecov-io commented 4 years ago

Codecov Report

Merging #18 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   80.26%   80.26%           
=======================================
  Files           2        1    -1     
  Lines         152      152           
=======================================
  Hits          122      122           
  Misses         30       30

Impacted Files	Coverage Δ
src/Electron.jl	`80.26% <100%> (+0.53%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f3fbb5c...6dc77b7. Read the comment docs.