search

davidanthoff / Electron.jl

Julia wrapper for Electron
Other
86 stars 19 forks source link

improve code reliability #9

Closed vtjnash closed 6 years ago

vtjnash commented 6 years ago

consolidate Window constructors hide internal Window and Application constructors try to avoid dying abrubtly on errors and exit avoid hang if url option is not passed to the Window constructor

codecov[bot] commented 6 years ago

Codecov Report

Merging #9 into master will decrease coverage by 10.78%. The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #9       +/-   ##
===========================================
- Coverage   97.82%   87.03%   -10.79%     
===========================================
  Files           1        1               
  Lines          92      108       +16     
===========================================
+ Hits           90       94        +4     
- Misses          2       14       +12
Impacted Files Coverage Δ
src/Electron.jl 87.03% <81.81%> (-10.79%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f5f47e...9c14d3d. Read the comment docs.