[Feature Request] Adding those without a profile picture to the filter

davidarroyo1234 / InstagramUnfollowers

Check if people follows you back on Instagram.

MIT License

2.98k stars 268 forks source link

[Feature Request] Adding those without a profile picture to the filter #193

Closed ramazansancar closed 2 months ago

ramazansancar commented 2 months ago

While browsing I noticed that the photo link IDs of those without profile pictures were all the same.

Maybe we can use this data to include those who want to filter those without a profile picture in the project.

44884218_345707102882519_2446069589734326272_n.jpg

davidarroyo1234 commented 2 months ago

Im not getting/reproducing the problem. Im being able to add to the whitelist someone without picture. And its only adding that person. Can you explain a bit more how to reproduce it please. @ramazansancar

ramazansancar commented 2 months ago

The development here allows Filters to separate those without a profile picture. There may be a confusion in the if control in the PR request. I asked for support there. @davidarroyo1234

Sorry for the late reply.

davidarroyo1234 commented 2 months ago

The development here allows Filters to separate those without a profile picture. There may be a confusion in the if control in the PR request. I asked for support there. @davidarroyo1234

Sorry for the late reply.

Oh my bad didnt understand the feature at first haha. LGTM. Maybe we should tweak a bit all the filters. But good job on the PR!

ramazansancar commented 2 months ago

Thanks but I think I may have made a mistake in the order here. When I tested it, it doesn't show anyone in the list without "Non-Followers" and "Followers" selected. (The 3rd image will explain.)

My dream way of working is: When "Without Profile Picture" is selected, it should show them from the entire list, and when it is removed, it should not show them. I may have made a mistake in the filter order. I'm not sure. Can you help me a little with this? @davidarroyo1234

ramazansancar commented 2 months ago

This is how it currently works:

davidarroyo1234 commented 2 months ago

Thanks but I think I may have made a mistake in the order here. When I tested it, it doesn't show anyone in the list without "Non-Followers" and "Followers" selected. (The 3rd image will explain.)

My dream way of working is: When "Without Profile Picture" is selected, it should show them from the entire list, and when it is removed, it should not show them. I may have made a mistake in the filter order. I'm not sure. Can you help me a little with this? @davidarroyo1234

Yeah also noticed that. Thats why i said "Maybe we should tweak a bit all the filters." because its not just your filter but all the filters has this cascade effect where. non followers or followers had to be turned on at least.

davidarroyo1234 commented 2 months ago

I will rework a bit all the filters so it can work a bit more friendly. Let me get some time. @ramazansancar

ramazansancar commented 2 months ago

I think a solution like group filter logic could solve the problem. @davidarroyo1234

List:

Non-Followers
Followers

Filters:

Verified
Private
Witout Profile Picture

How about this?

davidarroyo1234 commented 2 months ago

I think a solution like group filter logic could solve the problem. @davidarroyo1234

List:

Non-Followers

Followers

Filters:

Verified

Private

Witout Profile Picture

How about this?

Yeah, could be something like that. But the list should be both selectable. I mean Non followers or followers. Or both and then the filters

ramazansancar commented 1 month ago

Definitely, maybe the use of switches can make the design more understandable. Materialized design can be nice.

davidarroyo1234 commented 1 month ago

Definitely, maybe the use of switches can make the design more understandable. Materialized design can be nice.

Could be an option