davidavdav / GaussianMixtures.jl

Large scale Gaussian Mixture Models
Other
99 stars 38 forks source link

Update Clustering.jl #106

Closed BenCurran98 closed 1 year ago

BenCurran98 commented 1 year ago

Hi! I've noticed that Clustering.jl recently updated their code which has some backward-compatibility breaking changes. Is it possible to update the version in the Project.toml to 0.15? Thanks :slightly_smiling_face:

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.03 :tada:

Comparison is base (1789e42) 57.59% compared to head (1dcdcad) 57.63%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #106 +/- ## ========================================== + Coverage 57.59% 57.63% +0.03% ========================================== Files 12 13 +1 Lines 1066 1067 +1 ========================================== + Hits 614 615 +1 Misses 452 452 ``` [see 1 file with indirect coverage changes](https://codecov.io/gh/davidavdav/GaussianMixtures.jl/pull/106/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

BenCurran98 commented 1 year ago

@davidavdav Can you please have a look at this? Or else allow me to merge this? This package is now incompatible with some stuff my packages depend on :slightly_smiling_face: