search

davidavdav / GaussianMixtures.jl

Large scale Gaussian Mixture Models
Other
95 stars 36 forks source link

Update dependencies #68

Closed metab0t closed 3 years ago

davidavdav commented 3 years ago

Hi, thanks.

How does this patch pass the tests? I don't see CI output in this PR

metab0t commented 3 years ago

I have tested it locally and tests work fine on my machine. I don't know why CI is not triggered by this PR.

davidavdav commented 3 years ago

https://travis-ci.org/github/davidavdav/GaussianMixtures.jl after merge

metab0t commented 3 years ago

https://travis-ci.org/github/davidavdav/GaussianMixtures.jl after merge

The stacktrace of Julia nightly seems weird. The error happens in libuv functions.

nalimilan commented 3 years ago

Would it be possible to tag a new release? That would help for example https://github.com/cstjean/ScikitLearn.jl/pull/92.

davidavdav commented 3 years ago

@JuliaTagBot minor

nalimilan commented 3 years ago

Thanks, but I don't see any release in the General registry, and Project.toml still says 0.3.2. JuliaTagBot only creates tags, right?

(While you're at it, there are a few outstanding PRs bumping dependencies.)

davidavdav commented 3 years ago

I don't know. I've tried to release by using github release https://github.com/davidavdav/GaussianMixtures.jl/releases/tag/v0.3.3 but maybe that is not the way to release.

All the bots completely confuse me, the system keeps changing, and I have no idea how it currently works. I am with this guy https://discourse.julialang.org/t/release-a-new-version-of-registered-packages-again/47765

nalimilan commented 3 years ago

Yes now you have to update Project.toml, and then add a comment to a commit (not a PR) saying @JuliaRegistrator register. JuliaTagBot only creates tags afterwards (but that's somewhat independent from actual releases). You probably have to enable JuliaRegistrator on the project.

JuliaRegistrator commented 3 years ago

Error while trying to register: Register Failed @nalimilan, it looks like you don't have collaborator status on this repository.

davidavdav commented 3 years ago

Thanks, I hope it is done correctly now!

ExpandingMan commented 3 years ago

Hey guys, this never actually got tagged, can we tag this?