search

davidavdav / GaussianMixtures.jl

Large scale Gaussian Mixture Models
Other
95 stars 36 forks source link

Pluto support #90

Open fonsp opened 3 years ago

fonsp commented 3 years ago

Hi!

It looks like this package uses an internal API, making it incompatible with https://github.com/fonsp/Pluto.jl and other custom logging environemnts.

See https://github.com/fonsp/Pluto.jl/issues/1121

-fons

PavanChaggar commented 2 years ago

What's the status on this? I'm still getting the error: 

gmm
type PlutoLogger has no field min_level
getproperty(::Main.PlutoRunner.PlutoLogger, ::Symbol)@Base.jl:42
var"#GMMk#11"(::Symbol, ::Int64, ::Int64, ::Int64, ::typeof(GaussianMixtures.GMMk), ::Int64, ::Matrix{Float64})@train.jl:103
#GMM#9@train.jl:37[inlined]
GMM@train.jl:32[inlined]
top-level scope@[Local: 1](http://localhost:1234/edit?id=eab1dbc0-9e53-11ec-1b37-75a82665b36b#)[inlined]

I saw there was a PR that was not merged. If someone is able to advise on how to fix I can submit another PR.

PavanChaggar commented 2 years ago

I've fixed it (using the same changes as in the previous pr) and am just using a dev'd version of the package for now. What was the reason the pr was not merged?

davidavdav commented 2 years ago

Hello,

I am not sure. Somebody closed that PR, it wasn't me. Usually a PR has a bit more explanation on what is going on, and there should be some evidence that the normal tests are passed.

Probably automatic testing is broken at the moment, this package needs to move from travis to a github action.

PavanChaggar commented 2 years ago

Hey! Ok. I can open up another PR with the fixes and a bit more explanation.

PavanChaggar commented 2 years ago

opened #96 to address this. Let me know if I can do anything else.

PavanChaggar commented 2 years ago

Thanks for merging #96 :) Do you know roughly when the next release will be?

davidavdav commented 1 year ago

Sorry, I normally release immediately after a PR that passes the test. There should be 0.3.7 out soon.

davidavdav commented 1 year ago

I am not sure it succeeded, but it might be that version 0.3.6 is available now.

It turned out I already had the new testing infrastructure configured.

On Wed, Mar 9, 2022 at 11:53 AM Pavan Chaggar @.***> wrote:

Thanks for merging #96 https://github.com/davidavdav/GaussianMixtures.jl/pull/96 :) Do you know roughly when the next release will be?

— Reply to this email directly, view it on GitHub https://github.com/davidavdav/GaussianMixtures.jl/issues/90#issuecomment-1062796435, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJ6DV4AYRG44D37T4T2H6TU7B7K3ANCNFSM432R6N5Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

-- David van Leeuwen (다빛, 大卫, دافد)