search

davidavdav / GaussianMixtures.jl

Large scale Gaussian Mixture Models
Other
99 stars 38 forks source link

Fix compat #95

Closed yuehhua closed 3 years ago

yuehhua commented 3 years ago

Closed #94.

yuehhua commented 3 years ago

I got several deps updated and tests passed.

yuehhua commented 3 years ago

@davidavdav I added CI for this package. It will run all unit tests automatically. Now you can approve to trigger CI to start running.

codecov-commenter commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@bde052f). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage        ?   57.18%           
=======================================
  Files           ?       12           
  Lines           ?      995           
  Branches        ?        0           
=======================================
  Hits            ?      569           
  Misses          ?      426           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bde052f...51f6142. Read the comment docs.

davidavdav commented 3 years ago

Great, you found the bug with the matrix conversion. I was stuck there as I couldn't find the culprit.

yuehhua commented 3 years ago

Then you can fire a patch release.