davidavdav / NamedArrays.jl

Julia type that implements a drop-in replacement of Array with named dimensions
Other
120 stars 20 forks source link

Use testsets #125

Closed andreasnoack closed 1 year ago

andreasnoack commented 1 year ago

It makes failures more informative and it also avoids a lot of global variables in the testing.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 60.00% and project coverage change: +0.12 :tada:

Comparison is base (bfb912f) 83.61% compared to head (8e48dea) 83.74%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #125 +/- ## ========================================== + Coverage 83.61% 83.74% +0.12% ========================================== Files 15 15 Lines 647 646 -1 ========================================== Hits 541 541 + Misses 106 105 -1 ``` | [Impacted Files](https://codecov.io/gh/davidavdav/NamedArrays.jl/pull/125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/indexedtables.jl](https://codecov.io/gh/davidavdav/NamedArrays.jl/pull/125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2luZGV4ZWR0YWJsZXMuamw=) | `0.00% <0.00%> (ø)` | | | [src/iterators.jl](https://codecov.io/gh/davidavdav/NamedArrays.jl/pull/125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2l0ZXJhdG9ycy5qbA==) | `77.77% <100.00%> (ø)` | | | [src/names.jl](https://codecov.io/gh/davidavdav/NamedArrays.jl/pull/125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL25hbWVzLmps) | `100.00% <100.00%> (ø)` | | | [src/show.jl](https://codecov.io/gh/davidavdav/NamedArrays.jl/pull/125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3Nob3cuamw=) | `97.14% <100.00%> (+0.68%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

davidavdav commented 1 year ago

Thanks!

andreasnoack commented 1 year ago

@davidavdav I should have made it more obvious but this PR was based on top of #124 to avoid conflicts assuming that #124 would be merged before this one. The other one can just be closed if you are okay with the content of #124.

davidavdav commented 1 year ago

... but the merge succeeded, so I guess everything is all right now. I did see those diffs

andreasnoack commented 1 year ago

It would be great with a new release. InlineStrings are now pretty common since CSV produce them very often in the more recent versions so the issue in #123 show up frequently.

davidavdav commented 1 year ago

Hello,

version 0.9.7 has been released

---david

On Wed, Mar 22, 2023 at 8:28 PM Andreas Noack @.***> wrote:

It would be great with a new release. InlineStrings are now pretty common since CSV produce them very often in the more recent versions so the issue in #123 https://github.com/davidavdav/NamedArrays.jl/issues/123 show up frequently.

— Reply to this email directly, view it on GitHub https://github.com/davidavdav/NamedArrays.jl/pull/125#issuecomment-1480138385, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJ6DV3EJOJYVMUMVACJH5LW5NHEJANCNFSM6AAAAAAWDYXTWA . You are receiving this because you were mentioned.Message ID: @.***>

-- David van Leeuwen (다빛, 大卫, دافد)