Closed andreasnoack closed 1 year ago
Patch coverage: 60.00
% and project coverage change: +0.12
:tada:
Comparison is base (
bfb912f
) 83.61% compared to head (8e48dea
) 83.74%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks!
@davidavdav I should have made it more obvious but this PR was based on top of #124 to avoid conflicts assuming that #124 would be merged before this one. The other one can just be closed if you are okay with the content of #124.
... but the merge succeeded, so I guess everything is all right now. I did see those diffs
It would be great with a new release. InlineStrings
are now pretty common since CSV
produce them very often in the more recent versions so the issue in #123 show up frequently.
Hello,
version 0.9.7 has been released
---david
On Wed, Mar 22, 2023 at 8:28 PM Andreas Noack @.***> wrote:
It would be great with a new release. InlineStrings are now pretty common since CSV produce them very often in the more recent versions so the issue in #123 https://github.com/davidavdav/NamedArrays.jl/issues/123 show up frequently.
— Reply to this email directly, view it on GitHub https://github.com/davidavdav/NamedArrays.jl/pull/125#issuecomment-1480138385, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJ6DV3EJOJYVMUMVACJH5LW5NHEJANCNFSM6AAAAAAWDYXTWA . You are receiving this because you were mentioned.Message ID: @.***>
-- David van Leeuwen (다빛, 大卫, دافد)
It makes failures more informative and it also avoids a lot of global variables in the testing.