davidban77 / gns3fy

Python library wrapper around GNS3 Server REST API
https://davidban77.github.io/gns3fy/
57 stars 28 forks source link

extra validations for the Link attributes #104

Closed LucaV27 closed 2 years ago

LucaV27 commented 2 years ago

As discussed in a previous (and closed) PR (#99), I created a new PR from the "develop" branch. As the function of updating a GNS3 link was already uploaded in the above branch, I just added a minimum validator for "suspend" and "filters" fields.

codecov[bot] commented 2 years ago

Codecov Report

Merging #104 (d21a73d) into develop (d575625) will decrease coverage by 0.28%. The diff coverage is 77.77%.

@@             Coverage Diff             @@
##           develop     #104      +/-   ##
===========================================
- Coverage    99.85%   99.56%   -0.29%     
===========================================
  Files            3        3              
  Lines          689      697       +8     
===========================================
+ Hits           688      694       +6     
- Misses           1        3       +2     
Impacted Files Coverage Δ
gns3fy/gns3fy.py 99.56% <77.77%> (-0.30%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d575625...d21a73d. Read the comment docs.

Krlosromero commented 2 years ago

LGTM

Krlosromero commented 2 years ago

Thank you for your PR Luca