davidban77 / gns3fy

Python library wrapper around GNS3 Server REST API
https://davidban77.github.io/gns3fy/
57 stars 28 forks source link

added minor changes to create_link method #78

Closed agroveandtrie closed 4 years ago

agroveandtrie commented 4 years ago

Changed create_link method so that it sets the interface label text as the port name. fixes #70

davidban77 commented 4 years ago

Thanks! now I see what it was missing!.

This is great, can you change the PR to merge agains the develop branch instead of the master? That way I can check/change tests against this specific method.

Thanks!

agroveandtrie commented 4 years ago

I changed the PR to merge with the develop branch. Hopefully I did it correctly.

Krlosromero commented 4 years ago

LGTM @davidban77

ghost commented 4 years ago

any plans to merge this into master? We recently noticed the same behavior and traced it down to the same source. Was about to create an issue/PR, but now i found this.

davidban77 commented 4 years ago

@theister-xan thanks for pointing out, will be merging it to master soon and release a patch. In the meantime you can build from the develop branch