Closed brownhami closed 2 years ago
Tested against 2.2.25 and allowed the code below to complete within failing
gns3_project:
url: "{{ gns3_url }}"
port: "{{ gns3_port | default(omit) }}"
state: present
project_name: sonic
nodes_spec:
- name: leaf-1
template: SONiC latest
- name: tor-1
template: SONiC latest
- name: leaf-2
template: SONiC latest
- name: tor-2
template: SONiC latest
- name: PC1
template: VPCS
- name: PC2
template: VPCS
- name: PC3
template: VPCS
- name: PC4
template: VPCS
- name: PC5
template: VPCS
- name: PC6
template: VPCS
links_spec:
- ['leaf-1', 'Ethernet0', 'tor-1', 'Ethernet0']
- ['leaf-1', 'Ethernet1', 'tor-1', 'Ethernet1']
- ['leaf-1', 'Ethernet2', 'tor-2', 'Ethernet2']
- ['leaf-2', 'Ethernet0', 'tor-2', 'Ethernet0']
- ['leaf-2', 'Ethernet1', 'tor-2', 'Ethernet1']
- ['leaf-2', 'Ethernet2', 'tor-1', 'Ethernet2']
- ['PC1', 'Ethernet0', 'tor-1', 'Ethernet3']
- ['PC2', 'Ethernet0', 'tor-1', 'Ethernet4']
- ['PC3', 'Ethernet0', 'tor-1', 'Ethernet5']
- ['PC4', 'Ethernet0', 'tor-2', 'Ethernet3']
- ['PC5', 'Ethernet0', 'tor-2', 'Ethernet4']
- ['PC6', 'Ethernet0', 'tor-2', 'Ethernet5']
Can we call this issue as Fixed then ? considering that works for versions over 2.2.25 ? @cppmonkey
We would appreciate if this could get merged. It would eliminate the need to have to hand patch it on each new host we are using gns3fy on. We are running a near identical fix for some time without issues.
Tobias,
We are working on it for the upcoming days! Cheers
On Fri, 29 Oct 2021 at 13:51, Tobias Heister @.***> wrote:
We would appreciate if this could get merged. It would eliminate the need to have to hand patch it on each new host we are using gns3fy on. We are running a near identical fix for some time without issues.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/davidban77/gns3fy/pull/96#issuecomment-954717816, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEWYKN6RB63XJMXOX4Q6ER3UJKREJANCNFSM5CABUS5A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
Created Tests and Merged on #98 Thanks
I have only done a quick test with these changes to verify that 2.2.22 projects can now be loaded. I have not run the full test suite.