davidban77 / gns3fy

Python library wrapper around GNS3 Server REST API
https://davidban77.github.io/gns3fy/
57 stars 28 forks source link

Develop fix for Issue #96 #97

Closed Krlosromero closed 2 years ago

Krlosromero commented 3 years ago

Fixing issues for link_style attrs. Tests pased

= poetry run black --diff --check . All done! ✨ 🍰 ✨ 10 files would be left unchanged. poetry run pytest --cov-report=html --cov=gns3fy tests/

tests/test_drawing_utils.py ..... [ 3%] tests/test_gns3fy.py ........................................................................................................................................ [100%]

---------- coverage: platform darwin, python 3.8.5-final-0 ----------- Coverage HTML written to dir htmlcov

========================== 141 passed in 1.84s ==========================================

codecov[bot] commented 2 years ago

Codecov Report

Merging #97 (583c9aa) into master (d8f8737) will decrease coverage by 1.41%. The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   98.56%   97.15%   -1.42%     
==========================================
  Files           2        3       +1     
  Lines         695      737      +42     
==========================================
+ Hits          685      716      +31     
- Misses         10       21      +11     
Impacted Files Coverage Δ
gns3fy/gns3fy.py 97.10% <75.00%> (-1.44%) :arrow_down:
gns3fy/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d8f8737...583c9aa. Read the comment docs.

Krlosromero commented 2 years ago

Merged on #98