davidbanham / cavalry

The per-machine worker process for Field Marshal
3 stars 1 forks source link

Should check for valid nginx pid #4

Closed davidbanham closed 9 years ago

davidbanham commented 9 years ago

Just had an outage related to an nginx pidfile being present, but there being no string within it. This caused cavalry to think that nginx was running, so it did not start a new one. When it attempted to SIGHUP to apply a new configuration, however, the cavalry process barfed. this was due to attempt to send a signal to a PID that did not exist.

davidbanham commented 9 years ago

This issue was actually misconstrued. An invalid PID is handled just fine. The problem was the webserver coming up and accepting new routing tables before the nginx process was initialized. That has now been fixed. Yay!