search

davidbanham / express-async-errors

async/await support for ExpressJS
Other
900 stars 43 forks source link

Mostly travis tweaks, plus some small stuff #4

Closed scottmas closed 7 years ago

scottmas commented 7 years ago

David, you'll need to add the Travis info.

Also, using fn.call(this, ...) will get us slightly higher fidelity monkey patch behavior. I don't think Express ever relies on dynamic context, but just in case.

davidbanham commented 7 years ago

:+1:

bkeepers commented 6 years ago

This is causing some breakage in Probot https://github.com/probot/probot/issues/433.

I'm investigating if it's something we're doing wrong on our end, but wanted to report it in case it's affecting anyone else.

davidbanham commented 6 years ago

Thanks, @bkeepers. Let me know what you discover.