davidbarcons / mercury_oxford

Python drivers based in QCoDeS to control the mercury iTC and mercury iPS controllers from Oxford instruments.
0 stars 0 forks source link

Say thank you and add pressure setting function #1

Open TangTangGB opened 9 months ago

TangTangGB commented 9 months ago

Hi Davidbarcons,

Thank you for sharing you iTC and iPS driver. It is fantastic. I am a technical support engineer working for Oxford Instruments China. And running the Demo Lab here. I noticed that you did not add vti_pressure_setpoint parameter to the iTC driver which is undrstandable. I'm sure you've wondered why the SCPI command in manual doesn't work. I am deeply sorry that we have a bug here, iTC treat Pressure as Temperature. So the correct SCPI command is similar to setting the temperature. I added this parameters and tested that it worked. Please be free to add it to your Driver and refine it.

self.add_parameter('vti_pressure_setpoint', label='VTI pressure Setpoint', unit='mB', docstring='pressure setpoint for the VTI needlevalve', get_cmd="READ:" + self.pressure_str + ":LOOP:TSET?", get_parser=self._pressure_parser, set_cmd=lambda x: self.ask('SET:'+ self.pressure_str.replace('PRES','TEMP')+ f':LOOP:TSET:{x}') )

In addition, I would like to have your permission to recommend, introduce your Driver to my customers on Oxford Instruments website or social media to help them build the test system.

Thank you again for sharing it. Best!

TangTang

davidbarcons commented 9 months ago

Hi TangTang

Happy to hear you find it useful!

Thank you for your proposal! I invite you to do a pull request with this modification and I will accept it.

Please feel free to recommend this driver to your customers. However, I must say that I am not working anymore with those instruments and the driver will not be maintained from my side. I am open to discussing the possibility of transferring this driver to you so it can be updated, let me know.

Best regards,

David Barcons

TangTangGB commented 9 months ago

Hi David, It is soooooo nice of you. I am happy to keep it updated and adding more function to it. Do you know how to do the tansferr? But I don't know much about Github and Python. ( I used Labview before.) But I'll figure it out