Closed jonathanmorley closed 1 year ago
@davidbarsky, what is holding you back from merging this?
Sorry, I forgot to subscribe to this repo, so I didn't see any notification. I'm supposed to be maintaining this at present.
I am not sure of the intent behind https://github.com/davidbarsky/tracing-tree/commit/6e565e6c4c6fd50c4d338a628af7b45c741b069b. It appears to me that this introduced a bug where some extra indentation happens on certain lines but not others.
With no-indent-lines, this extra indentation is ambiguous as to whether it is introducing a real indent level or not.
The tests don't show this, but if you run the examples locally you can see that all the timestamps are padded in a way to always be of the same length (until you get to > 60 minutes). The tests strip the timestamps, so that's why they look weird.
I see, I have made #61 so that the tests can show this
Thanks! That's a lot better
Please rebase this PR on top of the main branch so we can see the difference your other PR makes to this one
Closes #43