davidbau / covid-19-chart

Chart of current COVID-19 time series data. Enables a variety of county- state- and nation-level comparisons and data exploration.
https://covid19chart.org/
18 stars 4 forks source link

Apply start rule to population-normalized data (not unnormalized) #44

Closed joshuahhh closed 4 years ago

joshuahhh commented 4 years ago

I'm not 100% sure about this, but...

When viewing population-normalized data, a >=N start rule should apply to the normalized series, not the unnormalized ones. That is, it should be interpreted as ">=N per-million".

Why?

I'd be happy to make the change, if you felt that it would be helpful! (I would also adjust the ">=N" options to be more appropriate to "/pop" mode, when it is selected.)

Thanks a bunch.

davidbau commented 4 years ago

i agree, i think that will be an improvement, to have some ">=100/m" etc options that are available in pop mode.

davidbau commented 4 years ago

And when flipping between /pop and non-pop modes, it makes sense to automatically flip between >=100 to >=100/mil etc. @joshuahhh if you want to make a pull request, it's very appreciated!

davidbau commented 4 years ago

Thanks @dmaymudes! Pushed the fix.