davidben / merkle-tree-certs

Other
9 stars 4 forks source link

Rebase the draft on top of draft-beck-tls-trust-anchor-ids #87

Closed davidben closed 3 months ago

davidben commented 4 months ago

The main changes:

Fixes #80

bwesterb commented 3 months ago

Bit of a nit, but why

struct {
    TrustAnchorIdentifier trust_anchor;
    opaque proof_data<0..2^16-1>;
} Proof;

struct {
    Assertion assertion;
    Proof proof;
} BikeshedCertificate;

and not directly

struct {
    Assertion assertion;
    TrustAnchorIdentifier trust_anchor;
    opaque proof_data<0..2^16-1>;
} BikeshedCertificate;

You could say the proof_data doesn't make sense without the trust_anchor, but the proof_data also doesn't make sense without the assertion.

davidben commented 3 months ago

@bwesterb Somewhat looking forward to maybe doing something like https://github.com/davidben/tls-trust-expressions/issues/54, but yeah, let's inline it for now.

(I was OOO last week. Will take a pass to update this and look it over again.)

bwesterb commented 3 months ago

@bwesterb Somewhat looking forward to maybe doing something like davidben/tls-trust-expressions#54, but yeah, let's inline it for now.

I don't see how that'd work, but let's keep it as is then if you have something in mind.

davidben commented 3 months ago

Sketched it out in https://github.com/davidben/merkle-tree-certs/issues/88