davidberenstein1957 / fast-sentence-transformers

Simply, faster, sentence-transformers
MIT License
140 stars 10 forks source link

max length setting #15

Closed DeoLeung closed 5 months ago

DeoLeung commented 1 year ago

https://github.com/davidberenstein1957/fast-sentence-transformers/blob/main/fast_sentence_transformers/FastSentenceTransformer.py#L330

hi, I just wonder should this 512 be set from config.json's max_position_embeddings?

davidberenstein1957 commented 5 months ago

Sorry for the late response but I've got good news! Sentence Transformers has an awesome maintainer again @tomaarsen, along with awesome ONNX integrations through optimum, therefore I decided to archive this project. https://github.com/UKPLab/sentence-transformers. Take a look here https://www.philschmid.de/optimize-sentence-transformers.