davidbrochart / nbterm

Jupyter Notebooks in the terminal.
MIT License
753 stars 37 forks source link

Can't quit if kernel has quit #16

Open ivirshup opened 3 years ago

ivirshup commented 3 years ago

After quitting a kernel, e.g. having a notebook that looks like this:

          ┌──────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐^
In [1]:   │quit()                                                                                                            │ 
          └──────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘ 

control-q doesn't exit the editor.

version info

package versions ``` nbterm==0.0.7 - kernel-driver [required: Any, installed: 0.0.5] - python-dateutil [required: Any, installed: 2.8.1] - six [required: >=1.5, installed: 1.15.0] - pyzmq [required: Any, installed: 19.0.2] - rich [required: Any, installed: 10.1.0] - colorama [required: >=0.4.0,<0.5.0, installed: 0.4.4] - commonmark [required: >=0.9.0,<0.10.0, installed: 0.9.1] - pygments [required: >=2.6.0,<3.0.0, installed: 2.7.0] - typing-extensions [required: >=3.7.4,<4.0.0, installed: 3.7.4.3] - prompt-toolkit [required: >=3.0.16, installed: 3.0.18] - wcwidth [required: Any, installed: 0.2.5] - pygments [required: Any, installed: 2.7.0] - rich [required: Any, installed: 10.1.0] - colorama [required: >=0.4.0,<0.5.0, installed: 0.4.4] - commonmark [required: >=0.9.0,<0.10.0, installed: 0.9.1] - pygments [required: >=2.6.0,<3.0.0, installed: 2.7.0] - typing-extensions [required: >=3.7.4,<4.0.0, installed: 3.7.4.3] - typer [required: Any, installed: 0.3.2] - click [required: >=7.1.1,<7.2.0, installed: 7.1.2] ```

Using terminal on macOS, python 3.8

davidbrochart commented 3 years ago

Thanks for reporting, yes the kernel life management is very minimal right now. I will look into it.