search

davidbrochart / nbterm

Jupyter Notebooks in the terminal.
MIT License
753 stars 37 forks source link

Custom key bindings #18

Open oricou opened 3 years ago

oricou commented 3 years ago

Allow users to have their own Key bindings.

davidbrochart commented 3 years ago

shift-enter is going to be hard to have in the terminal, but PRs are welcome!

oricou commented 3 years ago

I know :-) Sorry but I don't have time.

BTW it would be nice to be able to run a cell without exiting the edit mode.

jarbus commented 3 years ago

Would LOVE to see vim keybinds for nbterm

davidbrochart commented 3 years ago

It depends what you are talking about, for the notebook mode's key bindings I think we'd like to stick as much as possible to the Notebook. For the edit mode, nothing has been done yet, but prompt-toolkit has been used for https://github.com/prompt-toolkit/pyvim, so we should definitely be able to support vim key bindings when typing into cells.

dclong commented 3 years ago

It would be awesome if the command mode support Vim keybindings as well.

ndtallant commented 3 years ago

I've managed to get a branch up with custom keybindings (I wanted something vim-like as well) and hope to send in a PR soon. How would you feel about a JSON file to put custom key bindings? If so, any thoughts on where it should go?

1kastner commented 3 years ago

That would be really helpful for people who struggle with some key bindings as documented in #23 !

Shahin-rmz commented 3 years ago

It depends what you are talking about, for the notebook mode's key bindings I think we'd like to stick as much as possible to the Notebook. For the edit mode, nothing has been done yet, but prompt-toolkit has been used for https://github.com/prompt-toolkit/pyvim, so we should definitely be able to support vim key bindings when typing into cells.

would love to help unfortunately lack of knowledge don't allow me yet. But waiting eagerly to see vim like Json of @ndtallant