search

davidbrochart / nbterm

Jupyter Notebooks in the terminal.
MIT License
745 stars 37 forks source link

Keybindings Ctrl+e and Ctrl+r don't work under Windows + git bash or Windows + Ubuntu in WSL mode #23

Open 1kastner opened 3 years ago

1kastner commented 3 years ago

Hi there, thanks for this great project!

I just tried it out. I created some cells and tried to run them. But somehow the key combinations Ctrl+e and Ctrl+r didn't get through so that I could never run the code cells. I guess this issue would be solved if I just created my custom key bindings and avoided the Ctrl key at all.

davidbrochart commented 3 years ago

Thanks @1kastner! If ctrl-e and ctrl-r are problematic, then maybe we should change it. These are different from the Notebook, which uses ctrl-enter and shift-enter, but I don't think it's possible to have them in the terminal. I'm open to suggestions.

ogrisel commented 3 years ago

This does not seem to work on macOS (11) either (using the default Terminal.app).

davidbrochart commented 3 years ago

Thanks for reporting @ogrisel, what about changing them to just e and r (without ctrl)? I guess this will be less problematic.

1kastner commented 3 years ago

For me that sounds totally fine!

Jacke commented 3 years ago

It's not working. Drop the CTRL button!!! I can't even quit from the notebook app, latest big sure fast mac laptop

twolodzko commented 3 years ago

On Ubuntu the key bindings do not work at all. The only thing I was able to do was to type text, but without tabs as they did not work. No way to run the cell etc. There is even no way to exit the app (I need to close the terminal). I tried it on two different Linux PC's. In both cases using the build-in gnome terminal app.

davidbrochart commented 3 years ago

I use Lubuntu, with LXTerminal. Maybe the key bindings interfere with GNOME Terminal?

manics commented 3 years ago

Interestingly Ctrl+e and Ctrl+r do work for me in WSL Ubuntu ¯\_(ツ)_/¯ Certain sequences of Ctrl+e/Ctrl+r/up-arrow/down-arrow seem to lead to 100% cpu usage, but I've no idea if that's related or some other bug- if I narrow it down I'll open a new issue.

1kastner commented 3 years ago

I just replaced the key bindings and when I reduced it to e or r, everything was fine.

dirkroorda commented 3 years ago

It could be that the bindings work fine, but that cell execution does not work. See #41 , #24. Also the problem of not quitting is caused by cells not running.