Open toaster opened 5 months ago
Hey, I think you're right that slowing down the testing is not really worth it for the fuzzy matchin. I'm not sure if you realized but not having existing reference images causes creation of them so with this PR it would be impossible to create new reference images.
Thanks for the thoughtfulness but I don't think we want to venture down this path with the test automation.
[…] so with this PR it would be impossible to create new reference images.
That’s not correct, the missing golden images are still being created.
@tonimelisma I would kindly ask you to reconsider your decision. This PR makes the missing golden images more visible by failing the tests and therefore the CI run but it still creates the missing golden images.
This PR contains some improvements which I made when working on a fuzzy image test. It does not affect any logic or test outcome.
But it changes the test behaviour: missing golden images now let the tests fail. Thus, they are detected by CI runs.