Closed n0vad3v closed 4 months ago
Hey @n0vad3v, thank you very much for the PR. Do you think you will have time finishing it?
Hi @tonimelisma I think this PR is ready to merge for now, however more testing might be needed on GIF images.
It looks like you've removed the StripMetadata parameter. I'm really sorry but we can't have breaking changes in the API. I know it's not optimal to have poorly working or nonfunctional parameters in the API but we can't break users' software.
Got it, now I'm adding StripMetadata
option back and added a note for it.
Thank you sir. Your contributions are always welcome!
In response to https://github.com/davidbyttow/govips/issues/359#issuecomment-2002981134
Changes:
GifExportParams
to tell users that different vips version will use different paramsStripMetadata
is removed aslibvips
does not support this function on GIFs, I've tried pass it in withVIPS_OBJECT(operation), "strip", params->stripMetadata,
, the output image remains the same.bitdepth
in early vips versionHowever this PR is not finished, I've found several problems here.
Dither
,Effort
orBitdepth
, the output image's sha256sum remains the sameset_gifsave_options
, only one parameter can be used with passed in multiple parameters, as belowBut, as different parameters will result in same output image, I'm not sure why this is happening.