search

davidbyttow / govips

A lightning fast image processing and resizing library for Go
MIT License
1.28k stars 199 forks source link

Add test to validate resizing of animated image. #443

Open TheKigen opened 3 months ago

TheKigen commented 3 months ago

This adds a test to the ImageRef.Resize functions to make sure when resizing an animated image that the correct scale is used to avoid unrolling the animated image.

See https://github.com/davidbyttow/govips/issues/350

TheKigen commented 3 months ago

I found the original PR that added the 0.5. This change breaks the test that one had so I'm going to do some research on why.

The scale without casting to int results in 99.84 on the test previously.

See https://github.com/davidbyttow/govips/pull/386

tonimelisma commented 2 months ago

Thanks @TheKigen. This bug has been haunting a bit too long. Greatly appreciated if you can look into it. Let me know when the PR is ready to review and merge

tonimelisma commented 1 month ago

Hey @TheKigen I would love it if you could look at helping finalize this PR. Do you have any time in the near future to look at this?

TheKigen commented 1 month ago

Hi, @tonimelisma just been busy with a work trip this week. I'll try to get something done on it the weekend of Oct 5th.

tonimelisma commented 3 weeks ago

Hey @TheKigen - thanks for the input. I eagerly await your contributions. Thanks again for helping!